Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(craft): Add brew target on craft #406

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Aug 28, 2023

Adds brew target to automate publishing of sentry-wizard to our custom brew tap.

There's a change on craft needs to land before this one, to make it possible accessing checksums for sentry-wizard getsentry/craft#488

Closes #346

@github-actions
Copy link

github-actions bot commented Aug 28, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9390992

.craft.yml Show resolved Hide resolved
@romtsn romtsn changed the title feat(publishing): Add brew target on craft feat(craft): Add brew target on craft Aug 28, 2023
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm. We just need to be sure that when people run the wizard they actually run the latest version of it - otherwise they might get stale installation setups.

When we add this to the docs we may want to tell users to brew update beforehand.

@romtsn romtsn merged commit 5b76c51 into master Aug 30, 2023
9 checks passed
@romtsn romtsn deleted the rz/feat/craft-brew-config branch August 30, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry Wizard available via brew
4 participants