Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cleanup_mapping_file function #38

Closed
wants to merge 3 commits into from

Conversation

loewenheim
Copy link
Contributor

@loewenheim loewenheim commented Apr 17, 2024

This function removes everything from a proguard file that we don't need for mapping: fields and any header that isn't "sourceFile".

The purpose of this is to reduce the disk footprint of proguard files in Symbolicator.

Also includes a drive-by refactor of has_line_info.

@loewenheim loewenheim requested a review from a team April 17, 2024 10:49
@loewenheim loewenheim self-assigned this Apr 17, 2024
src/mapping.rs Show resolved Hide resolved
src/mapping.rs Outdated Show resolved Hide resolved
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, ignore me then. this predates lending iterators (if they are even possible today)

@loewenheim loewenheim requested a review from anonrig April 17, 2024 14:21
@loewenheim
Copy link
Contributor Author

Rendered obsolete by #42 .

@loewenheim loewenheim closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants