feat: Introduce ProguardCache format #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
reviewed
Jul 2, 2024
Co-authored-by: Arpad Borsos <arpad.borsos@sentry.io>
Swatinem
reviewed
Jul 2, 2024
Swatinem
approved these changes
Jul 3, 2024
loewenheim
added a commit
to getsentry/symbolicator
that referenced
this pull request
Jul 4, 2024
Based on getsentry/rust-proguard#42. This should significantly increase proguard processing performance by eliminating the time it takes to parse proguard files, at a slight cost to remapping itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stable binary format similar to symcache. It has the exact same features as
ProguardMapper, but doesn't need to be loaded into memory. I haven't tested performance yet.There's also a bit of duplication, and some functions just refer to the
mappermodule.