Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 22.10.0 #1701

Closed
12 tasks done
hubertdeng123 opened this issue Sep 15, 2022 · 6 comments
Closed
12 tasks done

Release 22.10.0 #1701

hubertdeng123 opened this issue Sep 15, 2022 · 6 comments

Comments

@hubertdeng123
Copy link
Member

hubertdeng123 commented Sep 15, 2022

@aminvakil
Copy link
Collaborator

I do not remember if we had another release on weekend or not 😃

Are we going to have a release today for October?

@hubertdeng123
Copy link
Member Author

release is happening today!

@emmatyping emmatyping mentioned this issue Oct 17, 2022
9 tasks
@chadwhitacre
Copy link
Member

chadwhitacre commented Oct 17, 2022

We broke builds again. Post-mortem ...

What happened?

  1. noticed "force opt in for issue reporting" at the last minute
  2. attempted to address with Enforce error reporting for self-hosted #1753
  3. asked the right question but ended up with the wrong answer - we switched away from .reporterrors in Switch from .reporterrors file to flag + envvar #1697
  4. merged Enforce error reporting for self-hosted #1753 and broke builds

How do we get the release back on track?

Two options:

  1. Kick "force opt in for issue reporting" can down the road.
  2. Implement "force opt in for issue reporting" properly.

What can we do to prevent this from happening again?

  1. Standardize e2e testing #1756
  2. Learn to recognize a risky situation and escalate (from IC pov) or pay more attention (from EM pov).
  3. Practice more attention to detail.

@chadwhitacre
Copy link
Member

Now working through options on getsentry/sentry#40120 ...

  1. Set up a second container for the additional post process forwarder.
  2. Pin to an old snuba version.

@chadwhitacre
Copy link
Member

We are trying to land #1759 and then will delete the release branch and rerun the prepare action.

@chadwhitacre
Copy link
Member

Action items re: the Snuba changes ... would be caught earlier with:

@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants