Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make e2e tests more thorough #1761

Closed
2 tasks done
Tracked by #55
emmatyping opened this issue Oct 17, 2022 · 8 comments
Closed
2 tasks done
Tracked by #55

Make e2e tests more thorough #1761

emmatyping opened this issue Oct 17, 2022 · 8 comments

Comments

@emmatyping
Copy link
Contributor

emmatyping commented Oct 17, 2022

This tests code deeper in the pipeline that might have caught #1668

Task list:

  1. Add test for symbolification pipeline, based on test in Sentry repo #1888
  2. Add test for alerts/notifications to test the snuba pipeline #1887
@BYK
Copy link
Member

BYK commented Oct 19, 2022

@ethanhs the backup/restore dance is woefully undertested. I did some fixes and improvements there while writing the docs (it did not even work before that 😅). In the upgrade scenario, you may wanna add a backup/restore scenario too. That said it should only matter when there's a model/migration change.

@emmatyping emmatyping changed the title Add an alert to e2e tests Make e2e tests more thorough Oct 19, 2022
@emmatyping
Copy link
Contributor Author

Good idea! I think we've seen a couple of tickets about backup/restore, so it would be good to test that.

@emmatyping
Copy link
Contributor Author

Arpad suggested for testing symbolicator workflows:

That seems like a good idea, yes. To cover this particular usecase, you would need a test that uses all the builtin symbol servers. A Windows minidump perhaps. We should have one already in the main Sentry tests, though those tests are always testing the very latest symbolicator master.

@chadwhitacre
Copy link
Member

backup/restore

Punting to getsentry/sentry#36868, need to address more comprehensively.

@chadwhitacre
Copy link
Member

What else could/should we test?

SSO & integrations ... would involve many more moving parts, more difficult to test.

@chadwhitacre
Copy link
Member

Profiling should come in with #1838.

Replays (#1873)? Dynamic Sampling?

@chadwhitacre
Copy link
Member

FE? Not really worth doing here, leave that in sentry.

We want to exercise the containers, that's really the scope.

Do we have tests for updating settings?

@chadwhitacre
Copy link
Member

Closing with 1 of 2 completed.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants