Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split post process forwarders #1759

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Split post process forwarders #1759

merged 2 commits into from
Oct 17, 2022

Conversation

chadwhitacre
Copy link
Member

@chadwhitacre chadwhitacre commented Oct 17, 2022 •
edited
Loading

@chadwhitacre
Copy link
Member Author

Talked through this with @lynnagara on a call. We're testing this manually by trying to repro getsentry/sentry#40120 with and without this change.

@chadwhitacre chadwhitacre mentioned this pull request Oct 17, 2022
Closed
@chadwhitacre
Copy link
Member Author

We have red on master.

Waiting for green on branch ...

@chadwhitacre
Copy link
Member Author

I got "web container is unhealthy" twice on here and @hubertdeng123 has gotten it once so far. Hrm ... 🤔

@chadwhitacre
Copy link
Member Author

I tried again and it's healthy, seems gtm. 👍

@chadwhitacre
Upping healthcheck retries to 10
647f55a 
In manual testing we were seeing healthcheck failures for the web
container, upping the retries seems to assuage. Not 100% sure on cause
but seems okay in terms of risk/reward at this point (need to get a
release out).
@chadwhitacre chadwhitacre mentioned this pull request Oct 17, 2022
Closed
12 tasks
@hubertdeng123 hubertdeng123 self-requested a review October 17, 2022 21:32
@chadwhitacre
Copy link
Member Author

@hubertdeng123 reran with 647f55a and got green. 👍

@chadwhitacre
Copy link
Member Author

Force-merging to get #1701 back on track. We'll get CI on master.

@chadwhitacre chadwhitacre merged commit 4a02090 into master Oct 17, 2022
@chadwhitacre chadwhitacre deleted the cwlw/split-post-process-forwarders branch October 17, 2022 21:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hubertdeng123 hubertdeng123 hubertdeng123 approved these changes

@emmatyping emmatyping emmatyping approved these changes

@lynnagara lynnagara lynnagara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chadwhitacre @lynnagara @emmatyping @hubertdeng123