Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Edge case for swizzleClassNameExclude #4405

Merged
merged 6 commits into from
Oct 8, 2024
Merged

fix: Edge case for swizzleClassNameExclude #4405

merged 6 commits into from
Oct 8, 2024

Commits on Oct 7, 2024

  1. fix: Edge case for swizzleClassNameExclude 

    Skip creating transactions for UIViewControllers ignored for swizzling
via the option swizzleClassNameExclude. Due to some edge cases with nib
files, the SDK doesn't swizzle the loadView method of the
UIViewController subclasses, but instead, it swizzles the
UIViewController.loadView method directly. Although the SDK doesn't
swizzle the classes specified in swizzleClassNameExclude, it created
transactions. Now, this is fixed.

Fixes GH-4386
    @philipphofmann
    philipphofmann committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    153db3d View commit details
    Browse the repository at this point in the history

  2. fix: Swizzling RootUIViewController if ignored 

    The SDK didn't exclude the RootViewController from swizzling when
ignored by the option swizzleClassNameExclude. This is fixed now.

Fixes GH-4385
    @philipphofmann
    philipphofmann committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    9cfe1d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge branch 'main' into fix/swizzle-class-name-exclude

    @philipphofmann
    philipphofmann committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e653022 View commit details
    Browse the repository at this point in the history

  2. changelog

    @philipphofmann
    philipphofmann committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    d8a028a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/swizzle-class-name-exclude

    @philipphofmann
    philipphofmann committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8795af8 View commit details
    Browse the repository at this point in the history

  4. changelog

    @philipphofmann
    philipphofmann committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    feaec67 View commit details
    Browse the repository at this point in the history