-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add In Foreground to App context #1260
Conversation
Codecov ReportBase: 90.11% // Head: 90.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1260 +/- ##
==========================================
+ Coverage 90.11% 90.16% +0.04%
==========================================
Files 164 164
Lines 5121 5136 +15
==========================================
+ Hits 4615 4631 +16
+ Misses 506 505 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I'd like to add the Ideally, unhandled callbacks such as onError would return the faulty Isolate in the So its better to not report at all instead of reporting everything as the |
With Flutter 3.7 you can actually initialize Sentry Flutter on a background isolate, where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Add In Foreground to App context
💡 Motivation and Context
Relates to getsentry/team-mobile#36
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps