-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new app context that tells if the app is in the background or foreground #36
Comments
Add to context first then talk to search and storage for features on top of it. |
Having looked a bit further into this I think we should introduce a new attribute for this, as the existing ones do not cover this use case. Existing ProtocolQuoting @marandaneto this issue comment describes the thread attributes best
Existing Front EndHere we have a |
Yes, it needs to be a new field. |
@markushi getsentry/develop#728 helps for telling if the thread is the |
As far as I can see we need some front-end changes for this as well:
|
Sentry PR getsentry/sentry#43964 |
UI search keys getsentry/sentry#47446 |
SDKs and BE work is done, the only missing bits now is the FE, to show those properties on the UI. |
Btw for getsentry/sentry#44251 we already display In Foreground in the contexts section I guess the question is if we also want to promote it as tag and display in the tags section. If not, we could close the issue |
The in-foreground label is there, but the issue is still open because of #198 We should not promote anything as a tag, the info is in the event already, and the FE should just display it elsewhere. @kahest what's the approach we should take when everything on our end is done, but it depends on external work? this is a good example, this issue will remain open while the other team doesn't tackle the 2 issues left (FE work only), although they are created under the sentry repo already. |
Perfectly fine to close this on our end, no need to change the title IMO. The FE related items are clearly pointed out. |
I'll check who can take on the FE tasks |
This field should be queriable in the discover dashboard.
Today people rely on
was active: yes|no
but it's not 100% correct and aligned between platforms.Other option is looking into breadcrumbs, but that is not queriable in the discover dashboard.
We could add a tag but afaik SDKs should not add tags themselves.
in_foreground
flagmain
flag to threads andin_foreground
flag for app contexts sentry-java#2516in_foreground
to event app context sentry-react-native#2826main
flag.main
flag to threads andin_foreground
flag for app contexts sentry-java#2516Related issues for surfacing on product:
The text was updated successfully, but these errors were encountered: