Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Android): Add note about min api level for android profiler #10449

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

kahest
Copy link
Member

@kahest kahest commented Jun 19, 2024

DESCRIBE YOUR PR

Adds note about minimum Android API level required for Android Profiling.

Related:
getsentry/sentry-java#3392
getsentry/sentry-java#3478

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@kahest kahest requested review from markushi and stefanosiano June 19, 2024 15:04
Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 10:11am

Copy link

codecov bot commented Jun 19, 2024

Bundle Report

Changes will decrease total bundle size by 14 bytes ⬇️

Bundle name Size Change
sentry-docs-client 6.22MB 8 bytes ⬇️
sentry-docs-server 7.55MB 3 bytes ⬇️
sentry-docs-edge-server 479.46kB 3 bytes ⬇️

@kahest kahest requested a review from a team June 20, 2024 09:51
@kahest kahest merged commit 79101f8 into master Jun 20, 2024
6 checks passed
@kahest kahest deleted the kahest/android-profiling-min-api-level branch June 20, 2024 17:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants