Remove profiling timeout logic and disable profiling on API 21 #3478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
removed timeout logic from AndroidProfiler, as unused by the backend anyway, to fix potential profiling always or never running when one times out
removed API 21 from supported profiling versions, due to a crash
💡 Motivation and Context
Timeout logic of AndroidProfiler could make profiling run forever, if a transaction is started after another times out without finishing.
If a profile timed out and the transaction finished, profiling was not started anymore, due to a bug in the logic.
Relay drops timed out profiles anyway, so we don't need to handle them.
Also, profiling crash on API 21, which is 10 years old, so we dropped support for it.
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps