Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sourcemaps): Small fixes in webpack snippets #3835

Merged
merged 7 commits into from
Jul 6, 2021

Conversation

lobsterkatie
Copy link
Member

Nothing major here, mostly just carryover from comments on #3677 which didn't get in before it was merged.

  • Use devtool in all snippets so that sourcemaps are generated correctly
  • Fix setting devtool in nextjs (set it on config)
  • Remove stray configureWebpack wrapper in two snippets
  • Remove productionBrowserSourceMaps from nextjs config since we no longer use it
  • Remove SentryWebpackPluginOptions from nextjs snippet not using plugin

@vercel
Copy link

vercel bot commented Jul 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/BgxFk9vYGkMApYnzKHUZbonAkFx1
✅ Preview: https://sentry-docs-git-kmclb-sourcemaps-webpack-fixes-july-2021.sentry.dev

@lobsterkatie lobsterkatie force-pushed the kmclb-sourcemaps-webpack-fixes-july-2021 branch from d532133 to d8173cb Compare July 6, 2021 16:38
@lobsterkatie lobsterkatie merged commit 9ea3c00 into master Jul 6, 2021
@lobsterkatie lobsterkatie deleted the kmclb-sourcemaps-webpack-fixes-july-2021 branch July 6, 2021 17:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants