ref(nextjs): Stop setting redundant productionBrowserSourceMaps in config
#3765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
1999
added a commit
to 1999/sentry-javascript
that referenced
this pull request
Jun 30, 2021
…transport * upstream/master: fix(tracing): Add check for document.scripts in metrics (getsentry#3766) ref(nextjs): Stop setting redundant `productionBrowserSourceMaps` in config (getsentry#3765) test: Ensure withScope and run bubble up exceptions (getsentry#3764) ref(gatsby): Default release to empty string (getsentry#3759) fix(nextjs): Make `withSentryConfig` return type match given config type (getsentry#3760) misc: Fix typos (getsentry#3763) fix(node): Enable autoSessionTracking correctly (getsentry#3758) release: 6.8.0 meta: 6.8.0 changelog feat: Enable serialization of multiple DOM attributes for breadcrumbs. (getsentry#3755) ref: Leave only valid buffer implementation (getsentry#3744)
This was referenced Jun 30, 2021
lobsterkatie
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 6, 2021
Nothing major here, mostly just carryover from comments on #3677 which didn't get in before it was merged. - Use `devtool` in all snippets so that sourcemaps are generated correctly - Fix setting `devtool` in nextjs (set it on `config`) - Remove stray `configureWebpack` wrapper in two snippets - Remove `productionBrowserSourceMaps` from nextjs config since [we no longer use it](getsentry/sentry-javascript#3765) - Remove `SentryWebpackPluginOptions` from nextjs snippet not using plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
withSentryConfigboth setsproductionBrowserSourceMapstotruein the mainnextjsconfig and setsdevtooltosource-mapin the webpack config.It turns out, though, that the only thing the former change does is cause nextjs to make the latter change itself. (All other references to
productionBrowserSourceMapsin the nextjs code are merely type annotations or instances of passing the value from one function to another. The linked code is the only place that value is actually used.) Therefore, since we're making thedevtoolconfig change ourselves, theproductionBrowserSourceMapsconfig change is redundant, and can be removed.(Of the two config changes, we want to remove this one and not the
devtoolone, since we want sourcemaps for both server and client builds.devtoolaffects both, whereasproductionBrowserSourceMaps(as the name implies) only affects the client build.)