Skip to content

Commit

Permalink
chore: Bump to Xcode 16 on CI (#3635)
Browse files Browse the repository at this point in the history
Co-authored-by: @jamescrosswell
  • Loading branch information
bitsandfoxes authored Sep 30, 2024
1 parent 12c7d7c commit 804a80a
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
16 changes: 14 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
- "**.md"

env:
XCODE_VERSION: 15.4
XCODE_VERSION: 16

jobs:
build-sentry-native:
Expand Down Expand Up @@ -70,7 +70,13 @@ jobs:
if: github.ref_name != 'main' && !startsWith(github.ref_name, 'release/')
uses: styfle/cancel-workflow-action@85880fa0301c86cca9da44039ee3bb12d3bedbfa # Tag: 0.12.1

# We only use Xcode 15.4
- name: Setup Xcode
if: matrix.os == 'macos-latest'
run: |
sudo xcode-select --switch /Applications/Xcode_${{env.XCODE_VERSION}}.app/Contents/Developer
xcodebuild -version
# We only use Xcode 16
- name: Remove unused applications
if: matrix.os == 'macos-latest'
run: |
Expand Down Expand Up @@ -197,6 +203,12 @@ jobs:
with:
dotnet-version: 8.0.x

- name: Setup Xcode
if: matrix.os == 'macos-latest'
run: |
sudo xcode-select --switch /Applications/Xcode_${{env.XCODE_VERSION}}.app/Contents/Developer
xcodebuild -version
# Needed for Android SDK setup step
- uses: actions/setup-java@v4
with:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,8 @@ async Task VerifyAsync(HttpRequestMessage message)
[SkippableFact]
private async Task Profiler_ThrowingOnSessionStartup_DoesntBreakSentryInit()
{
Skip.If(TestEnvironment.IsGitHubActions);

SampleProfilerSession.ThrowOnNextStartupForTests = true;

var tcs = new TaskCompletionSource<string>();
Expand Down

0 comments on commit 804a80a

Please sign in to comment.