chore: CI and Xcode 16 #3635
Merged
chore: CI and Xcode 16 #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
Sep 27, 2024
| sudo xcode-select --switch /Applications/Xcode_${{env.XCODE_VERSION}}.app/Contents/Developer | ||
| xcodebuild -version | ||
|
|
||
| # We only use Xcode 16 |
There was a problem hiding this comment.
the source of truth to the version we use is pinned above, are we better off changing this comment to: "This has to align with the xcode version we depend on, see ABC env var for details
There was a problem hiding this comment.
If you mean the # We only use Xcode 16 comment then we could change it to "Remove unused Xcode versions"... that step is basically just to free disk space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog