Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename thread pool protocol keys to snake case #1472

Merged
merged 4 commits into from
Feb 11, 2022

Conversation

SimonCropp
Copy link
Contributor

fixes #1471

@SimonCropp
Copy link
Contributor Author

@bruno-garcia so should these be snake case as well?

    internal class MainSentryEventProcessor : ISentryEventProcessor
    {
        internal const string CultureInfoKey = "Current Culture";
        internal const string CurrentUiCultureKey = "Current UI Culture";
        internal const string MemoryInfoKey = "Memory Info";
        internal const string ThreadPoolInfoKey = "ThreadPool Info";
        internal const string IsDynamicCodeKey = "Dynamic Code";
        internal const string IsDynamicCodeCompiledKey = "Compiled";
        internal const string IsDynamicCodeSupportedKey = "Supported";

@getsentry getsentry deleted a comment from github-actions bot Feb 6, 2022
@bruno-garcia
Copy link
Member

bruno-garcia commented Feb 7, 2022

Either the way we want to show in the UI if not part of the protocol, or snake case and added to develop docs and changes in sentry UI to render nicely.

The "UI" culture is a known protocol I believe, just the key there is different because we add two instances.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have some snapshot or other type of tests to validate this?

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #1472 (988b513) into main (7fa7986) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1472      +/-   ##
==========================================
+ Coverage   84.25%   84.26%   +0.01%     
==========================================
  Files         219      219              
  Lines        7387     7387              
  Branches     1417     1417              
==========================================
+ Hits         6224     6225       +1     
  Misses        727      727              
+ Partials      436      435       -1     
Impacted Files Coverage Δ
src/Sentry/Internal/MainSentryEventProcessor.cs 97.34% <100.00%> (ø)
src/Sentry/Internal/MemoryInfo.cs 100.00% <100.00%> (ø)
src/Sentry/Internal/ThreadPoolInfo.cs 100.00% <100.00%> (ø)
src/Sentry/Exceptions/SentryStackFrame.cs 81.70% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fa7986...988b513. Read the comment docs.

@bruno-garcia bruno-garcia reopened this Feb 11, 2022
@bruno-garcia bruno-garcia merged commit 86c0fcd into main Feb 11, 2022
@bruno-garcia bruno-garcia deleted the Rename-thread-pool-protocol-keys-to-snake-case branch February 11, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename thread pool protocol keys to snake case
3 participants