-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose IsSystemModuleName as a public static function. #1493
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1493 +/- ##
==========================================
- Coverage 84.17% 84.17% -0.01%
==========================================
Files 219 219
Lines 7383 7388 +5
Branches 1420 1421 +1
==========================================
+ Hits 6215 6219 +4
Misses 732 732
- Partials 436 437 +1
Continue to review full report at Codecov.
|
i pushed a very minor xml doc improvement |
Looks good for me :) |
There's a new public API which doesn't match the PR title and has no changelog entry. |
#skip-changelog.
I don' believe this function belongs to SentryOptionsExtensions since it's not exactly an extension to SentryOptions so leaving it on SentryStackTraceFactory may be thet best place from what I say.
The goal of this PR is to expose IsSystemModuleName so a proper fix can be implemented for getsentry/sentry-unity#575