Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frames with namespace Mono are marked as InApp=true #575

Closed
bruno-garcia opened this issue Feb 18, 2022 · 3 comments · Fixed by #661
Closed

Frames with namespace Mono are marked as InApp=true #575

bruno-garcia opened this issue Feb 18, 2022 · 3 comments · Fixed by #661
Assignees
Labels
Bug Something isn't working

Comments

@bruno-garcia
Copy link
Member

            {
              "function": "Mono.Net.Security.AsyncProtocolRequest+<ProcessOperation>d__24.MoveNext",
              "raw_function": "Mono.Net.Security.AsyncProtocolRequest+<ProcessOperation>d__24.MoveNext ()",
              "lineno": 0,
              "in_app": true
            },
            {
              "function": "System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[TResult].SetResult",
              "raw_function": "System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[TResult].SetResult (TResult result)",
              "lineno": 0,
              "in_app": false
            },

This is surprising because: https://github.com/getsentry/sentry-dotnet/blob/b5acb724549bf201f8fa8d13da165a47e35b4b86/src/Sentry/SentryOptions.cs#L615

@bruno-garcia bruno-garcia added Platform: Unity Bug Something isn't working labels Feb 18, 2022
@lucas-zimerman lucas-zimerman self-assigned this Feb 18, 2022
@lucas-zimerman
Copy link
Collaborator

Not exactly, the error was captured using unity and not the .NET SDK
by calling Debug.LogError you'll skip the StackTrace factory and instead use the this

InApp = functionName != null
&& !functionName.StartsWith("UnityEngine", StringComparison.Ordinal)
&& !functionName.StartsWith("System", StringComparison.Ordinal)

@lucas-zimerman
Copy link
Collaborator

Waiting for a new release containing getsentry/sentry-dotnet#1493 to conclude this task in Unity.

@bruno-garcia
Copy link
Member Author

The .NET SDK is getting released right now as 3.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants