Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow setting SDK info (name & version) in manifest #2016

Merged
merged 5 commits into from
May 6, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented May 3, 2022

📜 Description

Enables users to override the SDK info

💡 Motivation and Context

This allows other SDKs that use sentry-cocoa internally to identify the events. Enables getsentry/sentry-unity#616

💚 How did you test it?

Added a test case

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets see what @marandaneto and @romtsn think about this

@vaind vaind force-pushed the feat/sdk-info-setting branch 2 times, most recently from 8751608 to 5474694 Compare May 4, 2022 07:32
@marandaneto
Copy link
Contributor

@vaind please target the 6.x.x branch, we are only fixing bugs on the current stable version -> main.

@vaind vaind changed the base branch from main to 6.x.x May 5, 2022 07:21
@vaind
Copy link
Collaborator Author

vaind commented May 5, 2022

@vaind please target the 6.x.x branch, we are only fixing bugs on the current stable version -> main.

done

@codecov-commenter
Copy link

Codecov Report

Merging #2016 (42c3ddf) into 6.x.x (e7e9e9c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              6.x.x    #2016   +/-   ##
=========================================
  Coverage     80.79%   80.79%           
  Complexity     3146     3146           
=========================================
  Files           228      228           
  Lines         11645    11645           
  Branches       1565     1565           
=========================================
  Hits           9409     9409           
  Misses         1649     1649           
  Partials        587      587           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e9e9c...42c3ddf. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@marandaneto marandaneto merged commit 09e75be into getsentry:6.x.x May 6, 2022
@vaind vaind deleted the feat/sdk-info-setting branch May 6, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants