-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK names to indicate built for the Unity package #616
Comments
This was referenced May 3, 2022
Should we keep the version part of the SDK info as is, or use the Unity SDK version? Some pros & cons of both solutions:
|
The changes in this repo are implemented and merged - everything except cocoa should work from the next release. For cocoa, we need to wait for getsentry/sentry-cocoa#1853 to be merged & update to the latest SDK. |
The final piece: the cocoa SDK PR just got merged and released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When investigating an event captured by the sentry-cocoa SDK, we inspect the event payload's
sdk.name
property. It says:sentry.cocoa
. This doesn't help us tell apart the build done through submodule in this repository, packaged with the Unity SDK. That information can help us troubleshoot issues and understand adoption of the SDK (of iOS apps in general vs iOS+Unity).There was a change in the sentry-native (getsentry/sentry-native#677) to change its name (issue: getsentry/sentry-java#1901) when building for Android. But that won't help us understand if that was a Unity Android build (packaged via this repo, UPM packaging).
The goal: Events captured by installing
sentry-unity
should reportsdk.name
as follows:sentry.dotnet.unity
sentry.java.android.unity
sentry.native.android.unity
sentry.cocoa.unity
sentry.cocoa.unity
sentry.native.unity
The text was updated successfully, but these errors were encountered: