Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK names to indicate built for the Unity package #616

Closed
6 tasks done
bruno-garcia opened this issue Mar 7, 2022 · 3 comments
Closed
6 tasks done

SDK names to indicate built for the Unity package #616

bruno-garcia opened this issue Mar 7, 2022 · 3 comments
Assignees

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Mar 7, 2022

When investigating an event captured by the sentry-cocoa SDK, we inspect the event payload's sdk.name property. It says: sentry.cocoa. This doesn't help us tell apart the build done through submodule in this repository, packaged with the Unity SDK. That information can help us troubleshoot issues and understand adoption of the SDK (of iOS apps in general vs iOS+Unity).

There was a change in the sentry-native (getsentry/sentry-native#677) to change its name (issue: getsentry/sentry-java#1901) when building for Android. But that won't help us understand if that was a Unity Android build (packaged via this repo, UPM packaging).

The goal: Events captured by installing sentry-unity should report sdk.name as follows:

  • C# errors: sentry.dotnet.unity
  • Android: Java/Kotlin: sentry.java.android.unity
  • Android: C, C++: sentry.native.android.unity
  • iOS: Objective-C, Swift, C, C++: sentry.cocoa.unity
  • macOS: Objective-C, Swift, C, C++: sentry.cocoa.unity
  • Windows: C, C++: sentry.native.unity
@vaind
Copy link
Collaborator

vaind commented May 4, 2022

Should we keep the version part of the SDK info as is, or use the Unity SDK version? Some pros & cons of both solutions:

  • unity SDK version everywhere:
    • pro: makes it possible to identify which Unity package the issue comes from; in turn, we can then also tell which native SDK version was used;
    • con: takes one more step to get to the native SDK version
  • keep native SDK version:
    • pro: we know right away (without the additional lookup) which native SDK version issued this event
    • con: no way to know which Unity package version was used to report this issue

@vaind vaind mentioned this issue May 4, 2022
9 tasks
@vaind
Copy link
Collaborator

vaind commented May 31, 2022

The changes in this repo are implemented and merged - everything except cocoa should work from the next release. For cocoa, we need to wait for getsentry/sentry-cocoa#1853 to be merged & update to the latest SDK.

@vaind
Copy link
Collaborator

vaind commented Jun 20, 2022

The final piece: the cocoa SDK PR just got merged and released.

@vaind vaind closed this as completed Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants