Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8] Bump @sentry/webpack-plugin in @sentry/gatsby & stop exposing options directly #9837

Closed
Tracked by #9508
mydea opened this issue Dec 14, 2023 · 0 comments · Fixed by #11292
Closed
Tracked by #9508

[v8] Bump @sentry/webpack-plugin in @sentry/gatsby & stop exposing options directly #9837

mydea opened this issue Dec 14, 2023 · 0 comments · Fixed by #11292
Assignees
@AbhiPrasad
Labels
Package: gatsby Issues related to the Sentry Gatsby SDK
Milestone
8.0.0

Comments

@mydea
Copy link
Member

mydea commented Dec 14, 2023

We want to bump the webpack-plugin version to latest in Gatsby, and also stop passing plugin options through directly so we can in the future update this easier without a breaking change.
@mydea mydea added the Package: gatsby Issues related to the Sentry Gatsby SDK label Dec 14, 2023
@mydea mydea added this to the 8.0.0 milestone Dec 14, 2023
@mydea mydea mentioned this issue Dec 14, 2023
Closed
@mydea mydea changed the title [v8] Bump @sentry/webpack-plugin in @sentry/gatsby & stop exposing options directly [v8] Bump @sentry/webpack-plugin in @sentry/gatsby & stop exposing options directly Dec 14, 2023
@AbhiPrasad AbhiPrasad mentioned this issue Feb 6, 2024
Closed
@AbhiPrasad AbhiPrasad self-assigned this Feb 6, 2024
@AbhiPrasad AbhiPrasad mentioned this issue Mar 26, 2024
Merged
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this issue Apr 19, 2024
@AbhiPrasad @cadesalaberry
feat(v8/gatsby): Update SDK initialization for gatsby (getsentry#11292)
05e6ed8 
This is quite the refactor, I recommend reading through the migration
docs to understand what the user facing API should be.

1. Remove deprecated SDK init via options

We used to initialize the SDK via Gatsby plugin options in the Gatsby
SDK. This is very restrictive though, and due to how Gatsby serializes
it's options can lead to bugs. Later on in v7 of the SDK we introduced a
`sentry.config.js` approach
([docs](https://docs.sentry.io/platforms/javascript/guides/gatsby/)).
This PR removes support for the plugin option deprecation.

- Remove automatic adding of `browserTracingIntegration`

Because of the plugin option initialization, we used to add
`browserTracingIntegration` integration automatically via SDK init. v8
removes this because of bundle size + we don't have good routing
instrumentation for gatsby.

- Upgrade gatsby webpack plugin to 2.0, and add option to configure it's
usage

resolves getsentry#9837 - I
called the option to control this `enableClientWebpackPlugin`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbhiPrasad AbhiPrasad

Labels
Package: gatsby Issues related to the Sentry Gatsby SDK
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

feat(v8/gatsby): Update SDK initialization for gatsby getsentry/sentry-javascript
2 participants
@mydea @AbhiPrasad