feat(v8/gatsby): Update SDK initialization for gatsby #11292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove deprecated SDK init via options - Remove automatic adding of browserTracingIntegration - Upgrade gatsby webpack plugin to 2.0, and add option to configure it's usage
AbhiPrasad
commented
Mar 26, 2024
| @@ -5731,18 +5731,6 @@ | |||
| resolved "https://registry.yarnpkg.com/@sentry/cli-win32-x64/-/cli-win32-x64-2.30.2.tgz#1e84df37e9f0e5743b42435f92982cf7dae5e6d8" | |||
| integrity sha512-gF9wSZxzXFgakkC+uKVLAAYlbYj13e1gTsNm3gm+ODfpV+rbHwvbKoLfNsbVCFVCEZxIV2rXEP5WmTr0kiMvWQ== | |||
|
|
|||
| "@sentry/cli@^1.74.4": | |||
| version "1.77.1" | |||
There was a problem hiding this comment.
bye bye sentry-cli v1 👋
This comment was marked as off-topic.
This comment was marked as off-topic.
size-limit report 📦
|
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
This is quite the refactor, I recommend reading through the migration docs to understand what the user facing API should be. 1. Remove deprecated SDK init via options We used to initialize the SDK via Gatsby plugin options in the Gatsby SDK. This is very restrictive though, and due to how Gatsby serializes it's options can lead to bugs. Later on in v7 of the SDK we introduced a `sentry.config.js` approach ([docs](https://docs.sentry.io/platforms/javascript/guides/gatsby/)). This PR removes support for the plugin option deprecation. - Remove automatic adding of `browserTracingIntegration` Because of the plugin option initialization, we used to add `browserTracingIntegration` integration automatically via SDK init. v8 removes this because of bundle size + we don't have good routing instrumentation for gatsby. - Upgrade gatsby webpack plugin to 2.0, and add option to configure it's usage resolves getsentry#9837 - I called the option to control this `enableClientWebpackPlugin`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite the refactor, I recommend reading through the migration docs to understand what the user facing API should be.
We used to initialize the SDK via Gatsby plugin options in the Gatsby SDK. This is very restrictive though, and due to how Gatsby serializes it's options can lead to bugs. Later on in v7 of the SDK we introduced a
sentry.config.jsapproach (docs). This PR removes support for the plugin option deprecation.browserTracingIntegrationBecause of the plugin option initialization, we used to add
browserTracingIntegrationintegration automatically via SDK init. v8 removes this because of bundle size + we don't have good routing instrumentation for gatsby.resolves #9837 - I called the option to control this
enableClientWebpackPlugin.