-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v8): Remove @sentry/tracing #10625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
mydea and
lforst
and removed request for
a team
February 12, 2024 18:28
AbhiPrasad
force-pushed
the
abhi-remove-sentry-tracing
branch
4 times, most recently
from
February 12, 2024 20:55
e6269a1
to
a2fbf8c
Compare
mydea
approved these changes
Feb 13, 2024
AbhiPrasad
force-pushed
the
abhi-remove-sentry-tracing
branch
from
February 13, 2024 18:54
a2fbf8c
to
9a60e59
Compare
size-limit report 📦
|
lforst
previously requested changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking because will preven the package from being published on v7
dev-packages/node-integration-tests/suites/tracing/auto-instrument/mysql/scenario.ts
Fixed
Show fixed
Hide fixed
dev-packages/node-integration-tests/suites/tracing/auto-instrument/mysql/scenario.ts
Fixed
Show fixed
Hide fixed
Lms24
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go from the publishing perspective! Also LGTM in general!
AbhiPrasad
force-pushed
the
abhi-remove-sentry-tracing
branch
from
February 22, 2024 21:20
2cec277
to
3ae2de2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8796
Aside from deleting the tracing package and all of it's references, it also moves some relevant tests into core.