Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v8): Remove @sentry/tracing #10625

Merged
merged 17 commits into from
Feb 23, 2024
Merged

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Feb 12, 2024

resolves #8796

Aside from deleting the tracing package and all of it's references, it also moves some relevant tests into core.

@AbhiPrasad AbhiPrasad requested review from a team, mydea and lforst and removed request for a team February 12, 2024 18:28
@AbhiPrasad AbhiPrasad force-pushed the abhi-remove-sentry-tracing branch 4 times, most recently from e6269a1 to a2fbf8c Compare February 12, 2024 20:55
@AbhiPrasad AbhiPrasad self-assigned this Feb 12, 2024
Copy link
Contributor

github-actions bot commented Feb 13, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.51 KB (-0.26% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.78 KB (-0.28% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.7 KB (-0.26% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.3 KB (-0.31% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33 KB (-0.57% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.89 KB (-0.58% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.91 KB (-0.65% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 30.91 KB (-0.64% 🔽)
@sentry/browser - Webpack (gzipped) 22.19 KB (-0.91% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.53 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.45 KB (+0.09% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.72 KB (+0.18% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.14 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.86 KB (+0.09% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.93 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.74 KB (+0.05% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.09 KB (-0.29% 🔽)
@sentry/react - Webpack (gzipped) 22.22 KB (-0.91% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.56 KB (-0.23% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 49.8 KB (-0.38% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.14 KB (0%)

lforst
lforst previously requested changes Feb 14, 2024
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking because will preven the package from being published on v7

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go from the publishing perspective! Also LGTM in general!

@Lms24 Lms24 dismissed lforst’s stale review February 22, 2024 15:09

Publish limitations are fixed

@AbhiPrasad AbhiPrasad merged commit 437d20a into develop Feb 23, 2024
97 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-remove-sentry-tracing branch February 23, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v8] Remove @sentry/tracing package
4 participants