Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v8): Remove @sentry/tracing #10625

Merged
merged 17 commits into from
Feb 23, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .craft.yml
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,7 @@ targets:
id: '@sentry-internal/eslint-config-sdk'
includeNames: /^sentry-internal-eslint-config-sdk-\d.*\.tgz$/

## 8. Deprecated packages we still release (but no packages depend on them anymore)
- name: npm
id: '@sentry/tracing'
includeNames: /^sentry-tracing-\d.*\.tgz$/

## 9. Experimental packages
## 8. Experimental packages
- name: npm
id: '@sentry/node-experimental'
includeNames: /^sentry-node-experimental-\d.*\.tgz$/
Expand Down
8 changes: 7 additions & 1 deletion MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,13 @@ to access and mutate the current scope.

## Deletion of `@sentry/hub` package (#10530)

`@sentry/hub` has been removed. All exports from `@sentry.hub` should be available in `@sentry/core`.
`@sentry/hub` has been removed. All exports from `@sentry/tracing` should be available in `@sentry/core` or in
`@sentry/browser` and `@sentry/node`.

## Deletion of `@sentry/tracing` package

`@sentry/tracing` has been removed. All exports from `@sentry/tracing` should be available in `@sentry/core` or in
`@sentry/browser` and `@sentry/node`.

## General API Changes

Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,6 @@ Besides the high-level SDKs, this repository contains shared packages, helpers a
development. If you're thinking about contributing to or creating a JavaScript-based SDK, have a look at the resources
below:

- [`@sentry/tracing`](https://github.com/getsentry/sentry-javascript/tree/master/packages/tracing): Provides
integrations and extensions for Performance Monitoring / Tracing.
- [`@sentry/replay`](https://github.com/getsentry/sentry-javascript/tree/master/packages/replay): Provides the
integration for Session Replay.
- [`@sentry/core`](https://github.com/getsentry/sentry-javascript/tree/master/packages/core): The base for all
Expand Down
1 change: 0 additions & 1 deletion dev-packages/browser-integration-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"@playwright/test": "^1.40.1",
"@sentry-internal/rrweb": "2.11.0",
"@sentry/browser": "7.100.0",
"@sentry/tracing": "7.100.0",
"axios": "1.6.0",
"babel-loader": "^8.2.2",
"html-webpack-plugin": "^5.5.0",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/* eslint-disable no-unused-vars */
import * as Sentry from '@sentry/browser';
// biome-ignore lint/nursery/noUnusedImports: Need to import tracing for side effect
import * as _ from '@sentry/tracing';

Sentry.addTracingExtensions();

window.Sentry = Sentry;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/* eslint-disable no-unused-vars */
import * as Sentry from '@sentry/browser';
// biome-ignore lint/nursery/noUnusedImports: Need to import tracing for side effect
import * as _ from '@sentry/tracing';

Sentry.addTracingExtensions();

window.Sentry = Sentry;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ window.Sentry = Sentry;
Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
sampleRate: 1,
integrations: [new Sentry.browserTracingIntegration()],
integrations: [Sentry.browserTracingIntegration()],
});

// This should not fail
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import * as Sentry from '@sentry/browser';
import { Integrations } from '@sentry/tracing';

window.Sentry = Sentry;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [new Integrations.BrowserTracing({ idleTimeout: 9000 })],
integrations: [new Sentry.BrowserTracing({ idleTimeout: 9000 })],
tracesSampleRate: 1,
});
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import * as Sentry from '@sentry/browser';
import { Integrations } from '@sentry/tracing';

window.Sentry = Sentry;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [
new Integrations.BrowserTracing({
new Sentry.BrowserTracing({
idleTimeout: 1000,
_experiments: {
enableHTTPTimings: true,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import * as Sentry from '@sentry/browser';
import { Integrations } from '@sentry/tracing';

window.Sentry = Sentry;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [new Integrations.BrowserTracing()],
integrations: [new Sentry.BrowserTracing()],
tracesSampleRate: 1,
});
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import * as Sentry from '@sentry/browser';
import { Integrations } from '@sentry/tracing';

window.Sentry = Sentry;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [
new Integrations.BrowserTracing({
new Sentry.BrowserTracing({
idleTimeout: 1000,
_experiments: {
enableInteractions: true,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import * as Sentry from '@sentry/browser';
import { Integrations } from '@sentry/tracing';

window.Sentry = Sentry;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [new Integrations.BrowserTracing({ enableLongTask: false, idleTimeout: 9000 })],
integrations: [new Sentry.BrowserTracing({ enableLongTask: false, idleTimeout: 9000 })],
tracesSampleRate: 1,
});
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import * as Sentry from '@sentry/browser';
import { Integrations } from '@sentry/tracing';

window.Sentry = Sentry;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [
new Integrations.BrowserTracing({
new Sentry.BrowserTracing({
idleTimeout: 9000,
}),
],
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import * as Sentry from '@sentry/browser';
import { Integrations } from '@sentry/tracing';

window.Sentry = Sentry;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [new Integrations.BrowserTracing()],
integrations: [new Sentry.BrowserTracing()],
tracesSampleRate: 1,
environment: 'staging',
});
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import * as Sentry from '@sentry/browser';
import { Integrations } from '@sentry/tracing';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [new Integrations.BrowserTracing()],
integrations: [new Sentry.BrowserTracing()],
tracesSampleRate: 1,
});
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import * as Sentry from '@sentry/browser';
import { Integrations } from '@sentry/tracing';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;
Expand All @@ -8,7 +7,7 @@ setTimeout(() => {
window._testTimeoutTimestamp = (performance.timeOrigin + performance.now()) / 1000;
Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [new Integrations.BrowserTracing()],
integrations: [new Sentry.BrowserTracing()],
tracesSampleRate: 1,
});
}, 250);
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import * as Sentry from '@sentry/browser';
import { startSpanManual } from '@sentry/browser';
import { Integrations } from '@sentry/tracing';

window.Sentry = Sentry;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [new Integrations.BrowserTracing()],
integrations: [new Sentry.BrowserTracing()],
tracesSampleRate: 1,
});

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [new Sentry.BrowserTracing({ tracePropagationTargets: [], tracingOrigins: ['http://example.com'] })],
tracesSampleRate: 1,
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [new Sentry.BrowserTracing({ tracingOrigins: ['http://example.com'] })],
tracesSampleRate: 1,
});
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import * as Sentry from '@sentry/browser';
import { Integrations } from '@sentry/tracing';

window.Sentry = Sentry;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [new Integrations.BrowserTracing()],
integrations: [new Sentry.BrowserTracing()],
tracesSampleRate: 1,
});
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import * as Sentry from '@sentry/browser';
import { Integrations } from '@sentry/tracing';

window.Sentry = Sentry;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [new Integrations.BrowserTracing({ tracingOrigins: [/.*/] })],
integrations: [new Sentry.BrowserTracing({ tracingOrigins: [/.*/] })],
environment: 'production',
tracesSampleRate: 1,
debug: true,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import * as Sentry from '@sentry/browser';
import { Integrations } from '@sentry/tracing';

window.Sentry = Sentry;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [
new Integrations.BrowserTracing({
new Sentry.BrowserTracing({
idleTimeout: 9000,
}),
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,14 +168,13 @@ class SentryScenarioGenerationPlugin {
? {
// To help Webpack resolve Sentry modules in `import` statements in cases where they're provided in bundles rather than in `node_modules`
'@sentry/browser': 'Sentry',
'@sentry/tracing': 'Sentry',
'@sentry/replay': 'Sentry',
'@sentry/integrations': 'Sentry',
'@sentry/wasm': 'Sentry',
}
: {};

// Checking if the current scenario has imported `@sentry/tracing` or `@sentry/integrations`.
// Checking if the current scenario has imported `@sentry/integrations`.
compiler.hooks.normalModuleFactory.tap(this._name, factory => {
factory.hooks.parser.for('javascript/auto').tap(this._name, parser => {
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"private": true,
"dependencies": {
"@sentry/react": "latest || *",
"@sentry/tracing": "latest || *",
"@testing-library/jest-dom": "5.14.1",
"@testing-library/react": "13.0.0",
"@testing-library/user-event": "13.2.1",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import * as Sentry from '@sentry/react';
import { BrowserTracing } from '@sentry/tracing';
import React from 'react';
import ReactDOM from 'react-dom/client';
import App from './App';
Expand All @@ -9,7 +8,7 @@ import reportWebVitals from './reportWebVitals';
Sentry.init({
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [new BrowserTracing()],
integrations: [Sentry.browserTracingIntegration()],

// We recommend adjusting this value in production, or using tracesSampler
// for finer control
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ import * as _SentryOpentelemetry from '@sentry/opentelemetry-node';
// biome-ignore lint/nursery/noUnusedImports:
import * as _SentryReplay from '@sentry/replay';
// biome-ignore lint/nursery/noUnusedImports:
import * as _SentryTracing from '@sentry/tracing';
// biome-ignore lint/nursery/noUnusedImports:
import * as _SentryTypes from '@sentry/types';
// biome-ignore lint/nursery/noUnusedImports:
import * as _SentryUtils from '@sentry/utils';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"@sentry/node": "latest || *",
"@sentry/opentelemetry-node": "latest || *",
"@sentry/replay": "latest || *",
"@sentry/tracing": "latest || *",
"@sentry/types": "latest || *",
"@sentry/utils": "latest || *",
"@sentry/wasm": "latest || *"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"dependencies": {
"@sentry/integrations": "latest || *",
"@sentry/node": "latest || *",
"@sentry/tracing": "latest || *",
"@sentry/types": "latest || *",
"express": "4.18.2",
"@types/express": "4.17.17",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { httpClientIntegration } from '@sentry/integrations';
import * as Sentry from '@sentry/node';
import '@sentry/tracing';
import express from 'express';

declare global {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"@hapi/hapi": "21.3.2",
"@sentry/integrations": "latest || *",
"@sentry/node": "latest || *",
"@sentry/tracing": "latest || *",
"@sentry/types": "latest || *",
"@types/node": "18.15.1",
"typescript": "4.9.5"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"private": true,
"dependencies": {
"@sentry/react": "latest || *",
"@sentry/tracing": "latest || *",
"@testing-library/jest-dom": "5.14.1",
"@testing-library/react": "13.0.0",
"@testing-library/user-event": "13.2.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
},
"pnpm": {
"overrides": {
"@sentry/node": "latest || *",
"@sentry/tracing": "latest || *"
"@sentry/node": "latest || *"
}
},
"type": "module"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
},
"pnpm": {
"overrides": {
"@sentry/node": "latest || *",
"@sentry/tracing": "latest || *"
"@sentry/node": "latest || *"
}
},
"type": "module"
Expand Down
6 changes: 0 additions & 6 deletions dev-packages/e2e-tests/verdaccio-config/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,6 @@ packages:
unpublish: $all
# proxy: npmjs # Don't proxy for E2E tests!

'@sentry/tracing':
access: $all
publish: $all
unpublish: $all
# proxy: npmjs # Don't proxy for E2E tests!

'@sentry/types':
access: $all
publish: $all
Expand Down
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"@hapi/hapi": "^20.3.0",
"@prisma/client": "3.15.2",
"@sentry/node": "7.100.0",
"@sentry/tracing": "7.100.0",
"@sentry/types": "7.100.0",
"@types/mongodb": "^3.6.20",
"@types/mysql": "^2.15.21",
Expand Down
Loading
Loading