-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GuzzleHttp 7 support #360
Comments
Hi @andrey-helldar, in time we can for sure. However we use HTTPlug under the hood and they have yet to release a Guzzle 7 adapter. I'm sure this will happen (issue/pr), but we have to wait for that at the moment. Since Guzzle 7 was released 5 days ago at the time of this comment, give it some time 😄 Edit: Also this will likely be fixed in https://github.com/getsentry/sentry-php-sdk and not in this package directly. |
In the package https://github.com/getsentry/sentry-php-sdk there is no way to create issue, so I opened it here in the parent project 🙂 Well, wait until they create the project 😊 |
Hi @stayallive, I think since Guzzle 7 is PSR-18 compliant (php-http/guzzle6-adapter#73 (comment)) there is no need to use an adapter for HTTPlug. Maybe it is possible to use sentry/sentry directly with Guzzle 7 instead of sentry/sdk? |
Yes, you are correct @Brenneisen, although I've not tested this method you should be able to replace the
The above should be equal to just having:
And you should be able to pull out / replace the We provide |
Hmm, this too is preventing from upgrading to Guzzle 7 as I've direct dependency in my application too:
The only other is https://github.com/wildbit/swiftmailer-postmark which has a PR ActiveCampaign/swiftmailer-postmark#27 but no one is doing anything there; but that package I can easily replace with a custom driver if must be. But commercially depending on Sentry prevents me from just removing it 😅 |
@mfn, for Postmark it's a bit "easier" since they directly depend on Guzzle and can just add If you want / must / require Guzzle 7 for some reason see here: #371 (comment). |
There is an workaround available (#360 (comment)) so I'm going to close this issue to track it on the main SDK repository since it's not only Laravel related but has effect on all PHP integrations. See getsentry/sentry-php#1059 for progress updates. |
Laravel since version 7.0 supports guzzlehttp/guzzle 7 versions.
The guzzlehttp/guzzle package released version 7.0.0 on June 27th.
Could you add support for your package?
The text was updated successfully, but these errors were encountered: