Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Guzzle 7 and PHP 7.3-7.4 #27

Closed
wants to merge 3 commits into from
Closed

Added support for Guzzle 7 and PHP 7.3-7.4 #27

wants to merge 3 commits into from

Conversation

GrahamCampbell
Copy link

@GrahamCampbell GrahamCampbell commented Feb 14, 2020

I've also corrected your code style, most notably, a bunch of tabs instead of spaces, in some of the files. Additionally, you were missing a license file (composer.json indicated MIT), and repository field was miss-used in in composer.json file (fixed).


NB This PR retains support for Guzzle 6 too, and also PHP 7.0-7.2. We end up with Guzzle 6 and 7 support, and PHP 7.0-7.4 support.

@GrahamCampbell
Copy link
Author

Ping.

@jesperbjerke
Copy link

@atheken is anyone able to merge this pull request?

This was referenced Jul 9, 2020
@GrahamCampbell
Copy link
Author

Friendly ping @atheken. :)

@GrahamCampbell
Copy link
Author

I suppose this package is dead. Someone should fork it to replace it.

@vladsandu
Copy link
Contributor

vladsandu commented Aug 28, 2020

@GrahamCampbell thank you for contributing to this library and we apologize for the great delay in getting to review this PR.

This looks good to me. Big thanks for fixing the coding style and working on the additional improvements.

If you are still interested in contributing, would it be possible to restore the deleted forked repository and re-create/re-open this PR? If possible, I would be more than happy to get this merged and released shortly after.

@mfn
Copy link
Contributor

mfn commented Sep 5, 2020

@vladsandu I took the liberty and created a … slightly smaller… PR ;) => #37

I totally understand @GrahamCampbell with all the changes in this PR, but let's take smaller steps, now that there's activity again.

@GrahamCampbell
Copy link
Author

If someone else wants to take over from where I left off, feel free. I don't have time to do anything more, sorry.

@mfn
Copy link
Contributor

mfn commented Sep 5, 2020

@GrahamCampbell awesome and thanks for showing the way 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants