-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Guzzle 7 and PHP 7.3-7.4 #27
Conversation
Ping. |
@atheken is anyone able to merge this pull request? |
Friendly ping @atheken. :) |
I suppose this package is dead. Someone should fork it to replace it. |
@GrahamCampbell thank you for contributing to this library and we apologize for the great delay in getting to review this PR. This looks good to me. Big thanks for fixing the coding style and working on the additional improvements. If you are still interested in contributing, would it be possible to restore the deleted forked repository and re-create/re-open this PR? If possible, I would be more than happy to get this merged and released shortly after. |
@vladsandu I took the liberty and created a … slightly smaller… PR ;) => #37 I totally understand @GrahamCampbell with all the changes in this PR, but let's take smaller steps, now that there's activity again. |
If someone else wants to take over from where I left off, feel free. I don't have time to do anything more, sorry. |
@GrahamCampbell awesome and thanks for showing the way 🙏 |
I've also corrected your code style, most notably, a bunch of tabs instead of spaces, in some of the files. Additionally, you were missing a license file (composer.json indicated MIT), and repository field was miss-used in in composer.json file (fixed).
NB This PR retains support for Guzzle 6 too, and also PHP 7.0-7.2. We end up with Guzzle 6 and 7 support, and PHP 7.0-7.4 support.