allow defining SENTRY_SDK_NAME externally

[bruno-garcia]

Is this a feasible solution to this issue? getsentry/sentry-java#1901

That assumes we can define SENTRY_SDK_NAME in the NDK CMakeLists or Gradle

[Swatinem]

the #endif was missing ;-)

Lets check if this works when integrated with the sentry-java build file.
I think it should be possible to just add that compile definiton to the sub-project there, otherwise you would actually need to make that a cmake option.

https://github.com/getsentry/sentry-java/blob/33aeeb081e38aac8da02fd4101b6dfeb25d424ce/sentry-android-ndk/CMakeLists.txt#L16

[bruno-garcia]

I spent more time than I'm willing to admit on this:

• Set cmake min version to 3.13, supposedly what supports what I wanted:
• use target_compile_definitions after add_directory
• this function doesn't support alias though

I suspect that because of add_library(sentry::sentry ALIAS sentry) it doesn't work. If I use target_compile_definitions(sentry PRIVATE SENTRY_SDK_NAME="sentry.native.android") in the CMakeLists of this repo, it works. If I use add_compile_definitions` in this CmakeLists it also works.

So I'm proposing a different solution, likely better anyway as it'll be less inviting for custom sdk names by folks compiling directly:

[bruno-garcia]

No change needed in the Android repo

[bruno-garcia]

I'll fix the tests during the week

[Mixaill]

Another approch would be something like.
Minimal changes to the external projects. Also it does not require for external project to known anything about this project internals.

#my_cool_project/Cmakelists.txt

...
set(SENTRY_SDK_NAME "another-sdk-name")
add_subdirectory(sentry-native)
...

#my_cool_project/sentry-native/Cmakelists.txt

...
if(DEFINED SENTRY_SDK_NAME)
    target_compile_definitions(sentry PRIVATE SENTRY_SDK_NAME="${SENTRY_SDK_NAME}")
endif()
...

//my_cool_project/sentry-native/include/sentry.h

...
#if !defined(SENTRY_SDK_NAME)
#    define SENTRY_SDK_NAME "sentry.native"
#endif
...

[bruno-garcia]

Another approch would be something like. Minimal changes to the external projects. Also it does not require for external project to known anything about this project internals.

#my_cool_project/Cmakelists.txt

...
set(SENTRY_SDK_NAME "another-sdk-name")
add_subdirectory(sentry-native)
...

#my_cool_project/sentry-native/Cmakelists.txt

...
if(DEFINED SENTRY_SDK_NAME)
    target_compile_definitions(sentry PRIVATE SENTRY_SDK_NAME="${SENTRY_SDK_NAME}")
endif()
...

//my_cool_project/sentry-native/include/sentry.h

...
#if !defined(SENTRY_SDK_NAME)
#    define SENTRY_SDK_NAME "sentry.native"
#endif
...

On a second thought I believe it's best if it's not 'configurable' as we don't want custom values to be pass in here resulting in different variations. The Android case is a special one

[marandaneto]

@Swatinem can we cut a release to get this into the Android SDK? Thanks.