Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some inconsistencies in setting transaction op/name/status in OpenTelemetry::SpanProcessor #1987

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jan 19, 2023

Fixes #1957

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 98.62% // Head: 98.63% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (192f99c) compared to base (c7ba35c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1987      +/-   ##
==========================================
+ Coverage   98.62%   98.63%   +0.01%     
==========================================
  Files         157      157              
  Lines        9956     9970      +14     
==========================================
+ Hits         9819     9834      +15     
+ Misses        137      136       -1     
Impacted Files Coverage Δ
...lemetry/lib/sentry/opentelemetry/span_processor.rb 100.00% <100.00%> (ø)
...y/spec/sentry/opentelemetry/span_processor_spec.rb 100.00% <100.00%> (ø)
sentry-resque/lib/sentry/resque.rb 100.00% <0.00%> (+2.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sl0thentr0py sl0thentr0py merged commit bf0b9b4 into master Jan 19, 2023
@sl0thentr0py sl0thentr0py deleted the neel/otel-inconsistencies branch January 19, 2023 18:14
@st0012 st0012 added this to the 5.8.0 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTEL] Span operation setting seems off
3 participants