Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Pin known-good nightly for coverage tests #398

Merged
merged 7 commits into from
Jan 19, 2022
Merged

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Jan 3, 2022

No description provided.

@Swatinem Swatinem requested a review from a team January 3, 2022 15:50
@Swatinem Swatinem changed the title fix: Pin last known good nightly for Code Coverage ci: Disable broken Code Coverage job Jan 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #398 (2d770fc) into master (b907d6f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   83.04%   83.03%   -0.01%     
==========================================
  Files          70       70              
  Lines        7751     7747       -4     
==========================================
- Hits         6437     6433       -4     
  Misses       1314     1314              

@Swatinem Swatinem changed the title ci: Disable broken Code Coverage job ci: Switch to cargo-llvm-cov Jan 6, 2022
@Swatinem
Copy link
Member Author

I consider this pretty much blocked on taiki-e/cargo-llvm-cov#122 right now, as any kind of coverage coming from doctests is not being considered. Unfortunately, we rely a lot on doctests for coverage.

@Swatinem Swatinem marked this pull request as draft January 10, 2022 10:21
@Swatinem Swatinem changed the title ci: Switch to cargo-llvm-cov ci: Pin known-good nightly for coverage tests Jan 18, 2022
@Swatinem Swatinem marked this pull request as ready for review January 18, 2022 11:26
@Swatinem Swatinem merged commit 6bf4985 into master Jan 19, 2022
@Swatinem Swatinem deleted the pin-cov-nightly branch January 19, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants