Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Pin known-good nightly for coverage tests #398

Merged
merged 7 commits into from
Jan 19, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ jobs:

- run: make testfast

# Code coverage instrumentation is current broken in recent Rust nightlies,
# as they fail processing with the following error:
# `Failed to load coverage: Truncated coverage data`
# https://github.com/taiki-e/cargo-llvm-cov/issues/128
codecov:
name: Code Coverage
runs-on: ubuntu-latest
Expand All @@ -135,7 +139,7 @@ jobs:
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: nightly
toolchain: nightly-2022-01-14
components: llvm-tools-preview
override: true

Expand All @@ -145,6 +149,13 @@ jobs:
with:
args: --workspace --all-features

# Or maybe switch to `cargo-llvm-cov` later once its doctests are fixed

#- uses: taiki-e/install-action@cargo-llvm-cov

#- run: cargo llvm-cov --all-features --workspace --doctests --lcov --output-path lcov.info

- uses: codecov/codecov-action@e156083f13aff6830c92fc5faa23505779fbf649
with:
directory: coverage
#files: lcov.info