-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor InApp logic from Stack Traces #661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some tests with InAppInclude and InAppExclude?
Or at least showing the |
src/Sentry.Unity/Integrations/UnityApplicationLoggingIntegration.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stefan Jandl <stefan.jandl@sentry.io>
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Refactor InApp logic from Stack Traces ([#661](https://github.com/getsentry/sentry-unity/pull/661)) If none of the above apply, you can opt out of this check by adding |
This replaces the hardcoded logic to decide if the Frame is InApp or not by the one used by the main SDK.
One question was raising during the development of this PR
Should we add the code
System.Diagnostics.Debug.Fail("This UnityLogException constructor should not be used, please use the one that gives the SentryOption as an argument.");
On
Since they are not intended to be use by us?
Close #575