Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor InApp logic from Stack Traces #661

Merged
merged 5 commits into from
Apr 12, 2022
Merged

Refactor InApp logic from Stack Traces #661

merged 5 commits into from
Apr 12, 2022

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Mar 24, 2022

This replaces the hardcoded logic to decide if the Frame is InApp or not by the one used by the main SDK.

One question was raising during the development of this PR

Should we add the code
System.Diagnostics.Debug.Fail("This UnityLogException constructor should not be used, please use the one that gives the SentryOption as an argument.");

On

        internal UnityLogException() : base()
        {
            LogString = "";
            LogStackTrace = "";
        }

        private UnityLogException(string message) : base(message)
        {
            LogString = "";
            LogStackTrace = "";
        }

        private UnityLogException(string message, Exception innerException) : base(message, innerException)
        {
            LogString = "";
            LogStackTrace = "";
        }

Since they are not intended to be use by us?

Close #575

@lucas-zimerman lucas-zimerman added the Feature New feature or request label Mar 24, 2022
@lucas-zimerman lucas-zimerman changed the title Refactor InApp logic Refactor InApp logic from Stack Traces Mar 24, 2022
@lucas-zimerman lucas-zimerman marked this pull request as ready for review March 25, 2022 17:21
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some tests with InAppInclude and InAppExclude?

src/Sentry.Unity/UnityLogException.cs Outdated Show resolved Hide resolved
@bruno-garcia
Copy link
Member

Or at least showing the Mono inApp thing now is fixed

Co-authored-by: Stefan Jandl <stefan.jandl@sentry.io>
@lucas-zimerman lucas-zimerman merged commit 83559dd into main Apr 12, 2022
@lucas-zimerman lucas-zimerman deleted the fix/InApp branch April 12, 2022 14:45
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Refactor InApp logic from Stack Traces ([#661](https://github.com/getsentry/sentry-unity/pull/661))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 5f37860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frames with namespace Mono are marked as InApp=true
3 participants