Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Destroy screenshot texture #1427

Merged
merged 4 commits into from
Aug 24, 2023
Merged

fix: Destroy screenshot texture #1427

merged 4 commits into from
Aug 24, 2023

Conversation

bitsandfoxes
Copy link
Contributor

This fixes a potential memory leak as Texture2D is a Unity object. Those are not garbage collected as readily.
Ideally, I would like to just cache the texture object instead of creating a new one every time. Let's see if we can make that work when we're refactoring this to make use of hints.

@bruno-garcia bruno-garcia merged commit 7a06d70 into main Aug 24, 2023
2 checks passed
@bruno-garcia bruno-garcia deleted the fix/screenshot branch August 24, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants