Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Destroy screenshot texture #1427

Merged
merged 4 commits into from
Aug 24, 2023
Merged

fix: Destroy screenshot texture #1427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11742f0
destroy texture
bitsandfoxes Aug 24, 2023
c881198
usings
bitsandfoxes Aug 24, 2023
37afdf5
cleanup
bitsandfoxes Aug 24, 2023
2dc6f43
Updated CHANGELOG.md
bitsandfoxes Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Fixes

- The screenshot capture no longer leaks memory ([#1427](https://github.com/getsentry/sentry-unity/pull/1427))

### Dependencies

- Bump Cocoa SDK from v8.9.4 to v8.10.0 ([#1422](https://github.com/getsentry/sentry-unity/pull/1422), [#1424](https://github.com/getsentry/sentry-unity/pull/1424), [#1425](https://github.com/getsentry/sentry-unity/pull/1425))
Expand Down
4 changes: 2 additions & 2 deletions src/Sentry.Unity/ScreenshotAttachment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
using System;
using System.IO;
using Sentry.Extensibility;
using Sentry.Unity.Integrations;
using UnityEngine;

namespace Sentry.Unity
Expand Down Expand Up @@ -102,6 +100,8 @@ internal byte[] CaptureScreenshot(int width, int height)
RenderTexture.ReleaseTemporary(renderTextureResized);

var bytes = screenshot.EncodeToJPG(_options.ScreenshotCompression);
Object.Destroy(screenshot);

_options.DiagnosticLogger?.Log(SentryLevel.Debug,
"Screenshot captured at {0}x{1}: {2} bytes", null, width, height, bytes.Length);
return bytes;
Expand Down