Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Runtime Init instrumentation #991

Merged
merged 47 commits into from
Oct 5, 2022
Merged

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Sep 28, 2022

Span & Transaction names need some discussion.

The goal here is to capture runtime initialization via spans i.e.
Screenshot 2022-09-30 at 14 21 22

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Runtime Init instrumentation ([#991](https://github.com/getsentry/sentry-unity/pull/991))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 83ef604

@vaind
Copy link
Collaborator

vaind commented Sep 28, 2022

Just from a quick look at the picture first, so that I don't forget: maybe drop the "unity" prefix? Seems unnecessary

CHANGELOG.md Outdated Show resolved Hide resolved
Base automatically changed from feat/scene-load-tx to main September 29, 2022 17:04
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

What's wrong with WebGL? Maybe add a comment to the class definition why it doesn't work there?

@bitsandfoxes
Copy link
Contributor Author

LGTM.

What's wrong with WebGL? Maybe add a comment to the class definition why it doesn't work there?

Tracking the WebGL limitation here #1000
It seems to be an issue with the UnityWebRequestTransport that errors when trying to send events when the SDK is initialized during SubsystemRegistration.

@bitsandfoxes bitsandfoxes merged commit 3083a58 into main Oct 5, 2022
@bitsandfoxes bitsandfoxes deleted the feat/startup-transaction branch October 5, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants