ref(slack): remove workspace app code #23545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeredithAnya
force-pushed
the
removeslack/API-1632
branch
from
d32999e to
079a47d
Compare
size-limit report
|
scefali
reviewed
Feb 2, 2021
| @@ -171,7 +171,4 @@ def reauthorize(self, data): | |||
| Each provider may have their own way of reauthorizing the | |||
| integration. | |||
| """ | |||
| if self.provider == "slack": | |||
There was a problem hiding this comment.
@MeredithAnya i think we can just remove this method and where it's used, no?
There was a problem hiding this comment.
yeah i wasn't sure if we should keep it if we needed to reauth in the future but like im removing all the frontend code and can always re-implement so yeah ill take that out
|
@MeredithAnya we also have a related TODO here: We can take care of that after but just want to make sure it doesn't get forgotten |
MeredithAnya
force-pushed
the
removeslack/API-1632
branch
from
c14f1e6 to
39799fb
Compare
scefali
approved these changes
Feb 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed any organization integrations that were still using the slack workspace app in #23211.
In removing a lot of the code, many tests had to be updated because they were using the workspace integrations to test. There is a field in the integration metadata for Slack integrations called
installation_type. This type can either bemigrated_to_botorborn_as_bot. Workspace integrations do not have this type set.