ref(slack): Remove slack-v2 creds and usage #23587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scefali
reviewed
Feb 3, 2021
MeredithAnya
force-pushed
the
slack-creds/API-1635
branch
from
e4b90bf to
2f33180
Compare
|
Confirming here that the following credentials have been updated:
The |
scefali
approved these changes
Feb 8, 2021
MeredithAnya
commented
Feb 9, 2021
|
|
||
| resp = self.client.post("/extensions/slack/action/", data=payload) | ||
| resp = self.client.post("/extensions/slack/action/", data=payload, **headers) |
There was a problem hiding this comment.
can't seem to get the signatures to match when I actually pass in the correct headers :(
MeredithAnya
force-pushed
the
slack-creds/API-1635
branch
from
8409f50 to
cfb2739
Compare
bruno-garcia
pushed a commit
that referenced
this pull request
Feb 12, 2021
* ref(slack): Remove slack-v2 creds and usage * update slack requests tests * dont need verification token * add broken test * mock signing secret
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once #23545 is merged and deployed, we will have removed basically all the functionality for slack workspace apps. The last piece is the app itself, and it's credentials.
IMPORTANT: This PR should only be merged AFTER we have updated our slack-v2 credentials to replace our slack credentials.
We started out with one slack app, our now deprecated workspace app. The credentials for this app are:
We then introduced a new Slack integration, the bot app. The credentials for that app are:
Now there is actually a third type of app which is a older bot app, this kind of bot app may still be used by self hosted sentry users, and may be using the
slack.verification-tokeninstead of the signing secret (though they should probably update their app to use the secret). But anyway this is the reason we need to keep that option, although sentry SaaS will not need it.mini clean up: we don't use the option
slack.legacy-appanymore, so getting rid of itSide Note: I'm mocking out the signing secret check in the endpoint tests because I couldn't get the payloads to match for some reason,I want to come back to this, but it isn't any worse that what it was before because these tests used the verification token which we don't use anymore