Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use proguard cache format #1491

Merged
merged 9 commits into from
Jul 4, 2024
Merged

feat: Use proguard cache format #1491

merged 9 commits into from
Jul 4, 2024

Conversation

loewenheim
Copy link
Contributor

@loewenheim loewenheim commented Jul 2, 2024 •
edited
Loading

This was referenced Jul 2, 2024
Closed
Closed
@loewenheim loewenheim self-assigned this Jul 2, 2024
@loewenheim loewenheim marked this pull request as ready for review July 4, 2024 09:10
@loewenheim loewenheim requested a review from a team July 4, 2024 09:10
Swatinem
Swatinem approved these changes Jul 4, 2024
View reviewed changes
Cargo.lock Outdated Show resolved Hide resolved
Swatinem
Swatinem requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, let me block this until you fix the zip dependency

@loewenheim loewenheim enabled auto-merge (squash) July 4, 2024 09:34
@loewenheim loewenheim merged commit bede054 into master Jul 4, 2024
12 checks passed
@loewenheim loewenheim deleted the feat/proguard-cache-format branch July 4, 2024 09:36
loewenheim added a commit to getsentry/sentry that referenced this pull request Jul 5, 2024
@loewenheim
ref(proguard): Reset LPQ budget to base value
3326482 
As of getsentry/symbolicator#1491
proguard processing times are much more reasonable.
We can use the base value for LPQ time now.
@loewenheim loewenheim mentioned this pull request Jul 5, 2024
Merged
loewenheim added a commit to getsentry/sentry that referenced this pull request Jul 8, 2024
@loewenheim
ref(proguard): Reset LPQ budget to base value (#73870)
298253c 
As of getsentry/symbolicator#1491 proguard
processing times are much more reasonable. We can use the base value for
LPQ time now.
priscilawebdev pushed a commit to getsentry/sentry that referenced this pull request Jul 11, 2024
@loewenheim @priscilawebdev
ref(proguard): Reset LPQ budget to base value (#73870)
c56aa02 
As of getsentry/symbolicator#1491 proguard
processing times are much more reasonable. We can use the base value for
LPQ time now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees

@loewenheim loewenheim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loewenheim @Swatinem