-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cache): Infrastructure to distinguish between errors caused by malformed objects vs cache-specific errors #511
Conversation
8288203
to
7722e79
Compare
92af72e
to
fc50844
Compare
7722e79
to
378b8ba
Compare
log::debug!("Fetched debug file from {:?}: {:?}", source, status); | ||
match status { | ||
DownloadStatus::Completed => { | ||
log::debug!("Fetched debug file from {:?}: {:?}", source, status); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to do that in this PR, but the debug logs here print all of the source information, including private S3 keys, etc to the console, so that is waaay to detailed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll create a follow-up PR that tries to address this in a simple way 👍
…just download errs this does not change the existing functionality, but simply adds in infrastructure to make it easy to switch over if needed.
349b7e6
to
a76e332
Compare
This is part 3 of a series of PRs focused on cache statuses. Like the others, if you haven't taken a look at the previous PRs and have no context on these changes, it may be helpful to take a look at those first: #509 #510
CacheSpecificError
#509)CacheStatus::CacheSpecificError
entries have different timeout behaviours based on the type of cache they belong to #516)Malformed
andCacheSpecificError
cache files #510)CacheSpecificError
cache status #512)This PR is focused on the downloaders. It adds documentation and extends them as needed so it's easy to (eventually) tell the difference between a malformed object and a cache-specific error. This PR makes no functional changes to symbolicator, and simply makes some changes in preparation for step 4.
#skip-changelog