-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cache): Use the CacheSpecificError
cache status
#512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relaxolotl
requested review from
flub,
Swatinem,
untitaker,
jan-auer,
loewenheim and
a team
July 30, 2021 21:47
This was referenced Jul 30, 2021
relaxolotl
force-pushed
the
feat/all-the-things
branch
from
July 30, 2021 21:51
6458222
to
9dfbdcd
Compare
Swatinem
approved these changes
Aug 4, 2021
loewenheim
approved these changes
Aug 4, 2021
relaxolotl
changed the title
feat(cache): Use the
feat(cache): Use the Aug 4, 2021
DownloadError
cache statusCacheSpecificError
cache status
relaxolotl
force-pushed
the
feat/error-granularity
branch
from
August 4, 2021 23:35
92af72e
to
fc50844
Compare
relaxolotl
force-pushed
the
feat/all-the-things
branch
from
August 5, 2021 02:50
853d10d
to
830d717
Compare
rebased this and updated the changes to reflect the change in definition to the new enum. as mentioned in the description, other changes in the diff:
|
loewenheim
approved these changes
Aug 5, 2021
relaxolotl
force-pushed
the
feat/error-granularity
branch
from
August 6, 2021 16:41
349b7e6
to
a76e332
Compare
relaxolotl
force-pushed
the
feat/all-the-things
branch
from
August 6, 2021 18:30
623a66c
to
a691d4d
Compare
Swatinem
approved these changes
Aug 19, 2021
Same thing though as with the noperm changes: please test this manually to make sure sentry backend/ui can deal with these new candidate infos being returned. |
relaxolotl
force-pushed
the
feat/all-the-things
branch
from
August 19, 2021 13:00
aed466a
to
83ec78d
Compare
Swatinem
added a commit
that referenced
this pull request
Sep 8, 2021
#512 downgraded our log from error to debug, but that means we stopped reporting download errors to S4S. This brings back S4S logging of download errors, but still skips unactionable permissions errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to the final part of my 4-part series to make gooder symbolicator cache statuses. This has a slightly larger number of requested reviewers than my other 3 PRs since it actually turns the switch on to use the new cache status that's being introduced. If you're interested, feel free to visit the other 3 PRs listed below to get a bit of an idea of what the diffs of those look like.
We are now at step 5 of this list:
CacheSpecificError
#509)CacheStatus::CacheSpecificError
entries have different timeout behaviours based on the type of cache they belong to #516)Malformed
andCacheSpecificError
cache files #510)CacheSpecificError
cache status #512) 👈 you are hereChanges
Unlike the other 3 PRs, this does make functional changes to symbolicator:
Updating cache-specific error cache entries to use the same expiration strategy as negative cache entriesThis is no longer needed, already done inCacheStatus::CacheSpecificError
entries have different timeout behaviours based on the type of cache they belong to #516 and the behaviour is locked behind the previous bullet pointNotable new behaviour