Refactor namer scheme, fix trailing digits #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
requested changes
Nov 4, 2021
There was a problem hiding this comment.
At present, namer.call("!@#$") and namer.call("") both return "" the first time. We should check for an empty sanitized string. Then we can drop the check in call_or.
It took me a while, but I eventually convinced myself that this will always produce distinct names. I don't object to landing this (with the above fixed), but I think it would be much simpler if we just ensured that sanitize never returns anything ending in _N. Then we can simply say, self.unique never contains anything ending in _N, so either we just added the string, or we added a novel numeric suffix.
jimblandy
approved these changes
Nov 5, 2021
kvark
added a commit
to kvark/naga
that referenced
this pull request
Dec 2, 2021
Merged
kvark
added a commit
that referenced
this pull request
Dec 2, 2021
|
Published in 0.7.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1508