Skip to content

Commit

Permalink
Set COPY_SRC/COPY_DST only based on Vulkan's TRANSFER_SRC/`TRAN…
Browse files Browse the repository at this point in the history
…SFER_DST` (#3366)

* remove `BLIT_SRC`/`BLIT_DST`

* add changelog entry
  • Loading branch information
teoxoy authored Jan 10, 2023
1 parent e7ca171 commit 98ddb40
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ Additionally `Surface::get_default_config` now returns an Option and returns Non

- Browsers that support `OVR_multiview2` now report the `MULTIVIEW` feature by @expenses in [#3121](https://github.com/gfx-rs/wgpu/pull/3121).

#### Vulkan

- Set `COPY_SRC`/`COPY_DST` only based on Vulkan's `TRANSFER_SRC`/`TRANSFER_DST` by @teoxoy in [#3366](https://github.com/gfx-rs/wgpu/pull/3366).

### Added/New Features

#### General
Expand Down
8 changes: 2 additions & 6 deletions wgpu-hal/src/vulkan/adapter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1476,15 +1476,11 @@ impl crate::Adapter<super::Api> for super::Adapter {
);
flags.set(
Tfc::COPY_SRC,
features.intersects(
vk::FormatFeatureFlags::TRANSFER_SRC | vk::FormatFeatureFlags::BLIT_SRC,
),
features.intersects(vk::FormatFeatureFlags::TRANSFER_SRC),
);
flags.set(
Tfc::COPY_DST,
features.intersects(
vk::FormatFeatureFlags::TRANSFER_DST | vk::FormatFeatureFlags::BLIT_DST,
),
features.intersects(vk::FormatFeatureFlags::TRANSFER_DST),
);
// Vulkan is very permissive about MSAA
flags.set(Tfc::MULTISAMPLE_RESOLVE, !format.describe().is_compressed());
Expand Down

0 comments on commit 98ddb40

Please sign in to comment.