Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set COPY_SRC/COPY_DST only based on Vulkan's TRANSFER_SRC/TRANSFER_DST #3366

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Jan 10, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Description
We don't use vkCmdBlitImage at all and

r8snorm
rg8snorm
rgba8snorm
rg11b10ufloat
rgb9e5ufloat

formats don't have VK_FORMAT_FEATURE_BLIT_DST_BIT but should be copyable.

Testing

@teoxoy teoxoy changed the title Remove BLIT_SRC/BLIT_DST Set COPY_SRC/COPY_DST only based on Vulkan's TRANSFER_SRC/TRANSFER_DST Jan 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3366 (595ff80) into master (e7ca171) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 595ff80 differs from pull request most recent head fb1c199. Consider uploading reports for the commit fb1c199 to get more accurate results

@@            Coverage Diff             @@
##           master    #3366      +/-   ##
==========================================
- Coverage   64.50%   64.50%   -0.01%     
==========================================
  Files          86       86              
  Lines       42710    42706       -4     
==========================================
- Hits        27551    27546       -5     
- Misses      15159    15160       +1     
Impacted Files Coverage Δ
wgpu-hal/src/vulkan/adapter.rs 78.42% <100.00%> (-0.07%) ⬇️
wgpu-core/src/hub.rs 60.67% <0.00%> (-0.16%) ⬇️
wgpu-core/src/validation.rs 58.93% <0.00%> (-0.14%) ⬇️
wgpu-hal/src/dx12/descriptor.rs 88.11% <0.00%> (+0.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nical nical merged commit 98ddb40 into gfx-rs:master Jan 10, 2023
@teoxoy teoxoy deleted the rem-blit-src-dst branch January 10, 2023 15:05
@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants