Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing TextureFormats #967

Closed
3 of 5 tasks
crowlKats opened this issue Oct 8, 2020 · 7 comments
Closed
3 of 5 tasks

Missing TextureFormats #967

crowlKats opened this issue Oct 8, 2020 · 7 comments
Labels
area: api Issues related to API surface help required We need community help to make this happen. type: enhancement New feature or request
Milestone
WebGPU Specificat...

Comments

@crowlKats
Copy link
Collaborator

crowlKats commented Oct 8, 2020 •
edited
Loading

Was going through the spec and noticed some formats that are missing from wgpu:

  • rgb9e5ufloat
  • stencil8
  • depth16unorm
  • depth24unorm-stencil8
  • depth32float-stencil8

also in the spec Bc6hRgbSfloat is called bc6h-rgb-float (without the s). Is this intentional?
@kvark
Copy link
Member

kvark commented Oct 8, 2020

rgb9e5ufloat and stencil8 are coming in #955
depth16unorm needs to be added (want to help?).
depth24unorm-stencil8 and depth32float-stencil8 are extensions, which also need to be added.

@kvark
Copy link
Member

kvark commented Oct 8, 2020

also in the spec Bc6hRgbSfloat is called bc6h-rgb-float (without the s). Is this intentional?

Please file and issue to https://github.com/gpuweb/gpuweb about this!

@kvark kvark transferred this issue from gfx-rs/wgpu-rs Oct 8, 2020
@kvark kvark added area: api Issues related to API surface help required We need community help to make this happen. type: enhancement New feature or request labels Oct 8, 2020
@crowlKats
Copy link
Collaborator Author

also in the spec Bc6hRgbSfloat is called bc6h-rgb-float (without the s). Is this intentional?

Please file and issue to https://github.com/gpuweb/gpuweb about this!

gpuweb/gpuweb#1141, so apparently it is intentional

@crowlKats
Copy link
Collaborator Author

depth16unorm needs to be added (want to help?).

I would, but I have very little knowledge about anything graphics related, so I cant really help there :/

@DasEtwas
Copy link
Contributor

I'm interested in having depth32float-stencil8. It enables using super high-res reversed z projection depth buffers with stencils, for e.g. deferred lighting in big scenes.

@cwfitzgerald
Copy link
Member

Any and all help appreciated :)

@kvark kvark added this to the WebGPU MVP milestone May 21, 2021
@cwfitzgerald cwfitzgerald mentioned this issue Jul 22, 2021
Merged
bors bot added a commit that referenced this issue Jul 22, 2021
@bors @cwfitzgerald
Merge #1703
753cc25 
1703: Add Rgb9e5Ufloat Format r=kvark a=cwfitzgerald

**Connections**

Addresses part of #967, a wgpu-hal followup to #955.

**Description**

This adds only `Rgb9e5Ufloat`. I removed the explicit numbering from the texture format so we don't have to constantly re-number things. The default numbering is identical to what we were doing.

**Testing**

All backends unconditionally support it, so little testing is needed.


Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
@gents83 gents83 mentioned this issue Aug 26, 2022
Merged
@teoxoy
Copy link
Member

teoxoy commented Nov 9, 2022

Current status:

Will close this issue since the only texture format remaining has its own issue now.

@teoxoy teoxoy closed this as completed Nov 9, 2022
Patryk27 pushed a commit to Patryk27/wgpu that referenced this issue Nov 23, 2022
@proydakov
Fixed compile-time error in spv fuzzer test. (gfx-rs#967)
753e960 
* Fixed compile-time error in spv fuzzer test.

error[E0061]: this function takes 2 arguments but 1 argument was supplied
   --> fuzz_targets/spv_parser.rs:7:19
    |
7   |     let _result = Parser::new(data.into_iter()).parse();
    |                   ^^^^^^^^^^^ ---------------- supplied 1 argument
    |                   |
    |                   expected 2 arguments
    |
note: associated function defined here
   --> /Users/evgeny.proydakov/repository/naga/src/front/spv/mod.rs:411:12
    |
411 |     pub fn new(data: I, options: &Options) -> Self {
    |            ^^^

error: aborting due to previous error

* Code review. Group imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: api Issues related to API surface help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Milestone
WebGPU Specification V1
Development

No branches or pull requests
5 participants
@kvark @cwfitzgerald @crowlKats @DasEtwas @teoxoy