Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating TextureFormat matching specs #2954

Merged
merged 15 commits into from
Sep 20, 2022
Merged

Updating TextureFormat matching specs #2954

merged 15 commits into from
Sep 20, 2022

Conversation

gents83
Copy link
Contributor

@gents83 gents83 commented Aug 11, 2022

Fixing compilation error - when doing a full clean:

error[E0599]: no variant or associated item named Depth24unormStencil8 found for enum GpuTextureFormat in the current scope
--> D:\a\INOX\INOX\extern\wgpu\wgpu\src\backend\web.rs:553:52
|
553 | TextureFormat::Depth24UnormStencil8 => tf::Depth24unormStencil8,
| ^^^^^^^^^^^^^^^^^^^^
| |
| variant or associated item not found in GpuTextureFormat
| help: there is a variant with a similar name: Depth24plusStencil8

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

wgpu/src/backend/web.rs Outdated Show resolved Hide resolved
@maxammann
Copy link
Contributor

I'd propose to merge this as soon as possible and do the other work in a separate pr. This is breaking our CI currently.

@gents83
Copy link
Contributor Author

gents83 commented Aug 26, 2022

Linking Missing TextureFormats #967

@gents83
Copy link
Contributor Author

gents83 commented Aug 26, 2022

Linking Texture Format Depth24unormStencil8 not exist in WebGPU #2942

@maxammann
Copy link
Contributor

Thanks @gents83 for rocking this PR :D

CHANGELOG.md Outdated Show resolved Hide resolved
wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
wgpu-hal/src/vulkan/conv.rs Outdated Show resolved Hide resolved
@maxammann
Copy link
Contributor

A few tests seem to fail.

       note: label = `texture Depth24PlusStencil8`
    Texture format Depth24PlusStencil8 can't be used due to missing features.
    Features DEPTH24PLUS_STENCIL8 are required but not enabled on the device

Should DEPTH24PLUS_STENCIL8 be required by default by wgpu?

@gents83
Copy link
Contributor Author

gents83 commented Sep 4, 2022

It should be ok now- need just a new review from @cwfitzgerald

@maxammann
Copy link
Contributor

Workaround right now is web-sys = "=0.3.58"

@gents83 gents83 changed the title Fix web target -> remove Depth24unormStencil8 not existing anymore Updating TextureFormat matching specs Sep 7, 2022
@gents83
Copy link
Contributor Author

gents83 commented Sep 16, 2022

Is there any chance to integrate this to fix the web target?

wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
@cwfitzgerald
Copy link
Member

Just have formatting and a merge conflict and we're g2g

Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec wise looks correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants