-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute pass benchmark #5767
Merged
Merged
Compute pass benchmark #5767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
approved these changes
Jun 25, 2024
Wumpf
force-pushed
the
compute-pass-benchmark
branch
from
June 29, 2024 12:59
b764128
to
012ba30
Compare
Wumpf
force-pushed
the
compute-pass-benchmark
branch
from
June 29, 2024 13:02
012ba30
to
ce1960b
Compare
Wumpf
force-pushed
the
compute-pass-benchmark
branch
from
June 30, 2024 11:24
888b3e9
to
58ae38e
Compare
Wumpf
force-pushed
the
compute-pass-benchmark
branch
from
June 30, 2024 11:40
58ae38e
to
4548b57
Compare
Despite some mitigations, Linux is failing this benchmark |
Wumpf
force-pushed
the
compute-pass-benchmark
branch
from
July 7, 2024 10:40
a6f4fd5
to
1a5a5df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
Adds a benchmark for compute pass recording, very similar to what we have for render passes.
The prime motivation for this was to figure out whether the extensive changes I made to compute pass recording made performance worse or better - in fact there are good reasons for either. The short answer: It improved by 4-10% pass time since before I started!! 🥳
Even better, including submit time the improvements are 10-30%, but this is very likely not associated with the compute pass recording refactors :)
Unfortunately those changes landed over a quite long period of time so unless someone bisects this carefully we won't know what caused it exactly. It could be that the "fully consume the pass" change caused these improvements (we now make use of the fact that a pass can't be submitted twice) but then again this is probably a wash since before compute pass lifetimes refactor work started, compute pass was a very simple data structure (now it has extensive resource ownership). So it's just as likely that something else caused this.
For this comparision, I backported the benchmarks to c1291bd. to check it out yourself use the
before-computepass-work-with-benches
branch on my fork.Raw results comparing
c1291bd1312a77be73954856d0e7728877232033
against this branch:Testing
it is a test!
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.