Skip to content

Commit

Permalink
fix: Add account url in dynamic config
Browse files Browse the repository at this point in the history
   frontend-component-header since version v.3.5 requires the
   the settings of ACCOUNT_SETTINGS_URL to exists as it uses
   it point to the account MFE.
   - openedx/frontend-component-header/pull/210 PR that
   add the setting the componenet
   - openedx/wg-build-test-release/issues/268 which this fixes
  • Loading branch information
ghassanmas committed Apr 25, 2023
1 parent 06c57f6 commit d09e411
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tutormfe/patches/openedx-lms-development-settings
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ MFE_CONFIG = {
"STUDIO_BASE_URL": "http://{{ CMS_HOST }}:8001",
"USER_INFO_COOKIE_NAME": "user-info",
"ACCESS_TOKEN_COOKIE_NAME": "edx-jwt-cookie-header-payload",
{% if MFE_ACCOUNT_MFE_APP %}
"ACCOUNT_SETTINGS_URL": "{{ "https" if ENABLE_HTTPS else "http" }}://{{ MFE_HOST }}/{{ MFE_ACCOUNT_MFE_APP["name"] }}",
{%- endif %}
{%- if MFE_LEARNING_MFE_APP %}
"LEARNING_BASE_URL": "http://{{ MFE_HOST }}:{{ MFE_LEARNING_MFE_APP["port"] }}",
{%- endif %}
Expand Down
3 changes: 3 additions & 0 deletions tutormfe/patches/openedx-lms-production-settings
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ MFE_CONFIG = {
"STUDIO_BASE_URL": "{{ "https" if ENABLE_HTTPS else "http" }}://{{ CMS_HOST }}",
"USER_INFO_COOKIE_NAME": "user-info",
"ACCESS_TOKEN_COOKIE_NAME": "edx-jwt-cookie-header-payload",
{% if MFE_ACCOUNT_MFE_APP %}
"ACCOUNT_SETTINGS_URL": "{{ "https" if ENABLE_HTTPS else "http" }}://{{ MFE_HOST }}/{{ MFE_ACCOUNT_MFE_APP["name"] }}",
{%- endif %}
{%- if MFE_LEARNING_MFE_APP %}
"LEARNING_BASE_URL": "{{ "https" if ENABLE_HTTPS else "http" }}://{{ MFE_HOST }}/{{ MFE_LEARNING_MFE_APP["name"] }}",
{%- endif %}
Expand Down

0 comments on commit d09e411

Please sign in to comment.