Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account link in User dropdown is failing on the Course pages #268

Closed
jswope00 opened this issue Apr 22, 2023 · 5 comments
Closed

Account link in User dropdown is failing on the Course pages #268

jswope00 opened this issue Apr 22, 2023 · 5 comments
Assignees
@ghassanmas
Labels
palm
Milestone
Palm.1

Comments

@jswope00
Copy link

From all tabs in a course, the 'Account' link in the User dropdown appears to be linking to itself, and so the link is not correctly directing the user to the Account page:
https://prnt.sc/_jcsuHqKwMed
@ghassanmas
Copy link
Member

I think I have also noticed that in MFEs, and it's probably something related to the header componenet. I will investage further as I think this probably affect few MFEs.

@ghassanmas ghassanmas self-assigned this Apr 25, 2023
@ghassanmas
Copy link
Member

ghassanmas commented Apr 25, 2023 •
edited
Loading

I think newer version of frontend-component takes the accout url from the settings thus tutor-mfe shall send it. I am looking into it

ghassanmas added a commit to ghassanmas/tutor-mfe that referenced this issue Apr 25, 2023
@ghassanmas
fix: Add account url in dynamic config
d09e411 
   frontend-component-header since version v.3.5 requires the
   the settings of ACCOUNT_SETTINGS_URL to exists as it uses
   it point to the account MFE.
   - openedx/frontend-component-header/pull/210 PR that
   add the setting the componenet
   - openedx/wg-build-test-release/issues/268 which this fixes
@ghassanmas ghassanmas mentioned this issue Apr 25, 2023
Merged
@ghassanmas
Copy link
Member

A fix is suggested @

@ghassanmas ghassanmas mentioned this issue Apr 25, 2023
Closed
@ghassanmas ghassanmas added this to the Palm.1 milestone Apr 25, 2023
ghassanmas added a commit to ghassanmas/tutor-mfe that referenced this issue May 16, 2023
@ghassanmas
fix: Add account url in dynamic config
8a2ccc0 
   frontend-component-header since version v.3.5 requires the
   the settings of ACCOUNT_SETTINGS_URL to exists as it uses
   it point to the account MFE.
   - openedx/frontend-component-header/pull/210 PR that
   add the setting the componenet
   - openedx/wg-build-test-release/issues/268 which this fixes
ghassanmas added a commit to ghassanmas/tutor-mfe that referenced this issue May 17, 2023
@ghassanmas
fix: Add account url in dynamic config
652e582 
   frontend-component-header since version v.3.5 requires the
   the settings of ACCOUNT_SETTINGS_URL to exists as it uses
   it point to the account MFE.
   - openedx/frontend-component-header/pull/210 PR that
   add the setting the componenet
   - openedx/wg-build-test-release/issues/268 which this fixes
ghassanmas added a commit to ghassanmas/tutor-mfe that referenced this issue May 17, 2023
@ghassanmas
fix: Add account url in dynamic config
7713864 
   frontend-component-header since version v.3.5 requires the
   the settings of ACCOUNT_SETTINGS_URL to exists as it uses
   it point to the account MFE.
   - openedx/frontend-component-header/pull/210 PR that
   add the setting the componenet
   - openedx/wg-build-test-release/issues/268 which this fixes
arbrandes pushed a commit to overhangio/tutor-mfe that referenced this issue May 18, 2023
@ghassanmas @arbrandes
fix: Add account url in dynamic config
2b9d23e 
   frontend-component-header since version v.3.5 requires the
   the settings of ACCOUNT_SETTINGS_URL to exists as it uses
   it point to the account MFE.
   - openedx/frontend-component-header/pull/210 PR that
   add the setting the componenet
   - openedx/wg-build-test-release/issues/268 which this fixes
@mariajgrimaldi
Copy link
Member

@ghassanmas: can we close this issue? Thank you so much for the fix!

@ghassanmas
Copy link
Member

No worries, yes I think it's resoveld now

@github-project-automation github-project-automation bot moved this from In progress to Done in Build-Test-Release Working Group May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghassanmas ghassanmas

Labels
palm
Projects
Build-Test-Release Working Group
Status: Done
Milestone
Palm.1
Development

No branches or pull requests
3 participants
@jswope00 @ghassanmas @mariajgrimaldi