Auto edit is not functioning

[roopeshkurian]

Describe the bug

Thank you for providing a wonderful and easy grid system. After upgrading to the latest version I found an issue.
autoEdit functionality is not working.
You can see it from the Editors example page.
https://ghiscoding.github.io/Angular-Slickgrid/#/editor

Reproduction

Please visit https://ghiscoding.github.io/Angular-Slickgrid/#/editor
then click Task 0 under the 'Title, Custom Editor' header. Then try to change the value. Then when we move to another cell old edited value is replaced with the old value.

Expectation

When we type new values and move to another cell, it should retain the newly entered values.

Environment Info

Angular 15.1.5
Angular-Slickgrid 5.5.1
TypeScript 4.9.5
Browser Mozilla 110
OS windows.

Validations

• Follow our Code of Conduct
• Read the HOWTO - Step by Step.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion.
• The provided reproduction is a minimal reproducible example of the bug.

[ghiscoding]

I'm not sure what you mean, I can't reproduce what you're described, it seems to be working fine on my side. Perhaps you can provide an animated gif of your problem? I use ShareX on Windows to create animated gif

Note that the main difference with autoCommitEdit is that it was a grid option that only existed in Angular-Slickgrid and it wasn't in the SlickGrid core lib. What I did was to add autoCommitEdit directly in the core lib, in this PR and this commit, now that it's part of the core lib, I no longer need to patch it in Angular-Slickgrid (actually in Slickgrid-Universal) and the patch was that it was navigating to the next bottom cell and I was forcing a re-navigate to the same cell position, now that it's in the core we no longer need to reforce a cell navigation since we aren't moving cell at all anymore when autoCommitEdit is enabled in the core.

[roopeshkurian]

In my local project, it does not work. So I thought of checking the Demo you uploaded. It does work for me there also. Can you please see the below gif? I will try in my code again.

[ghiscoding]

I need a way to replicate the issue or else I'm afraid that I can't do much in troubleshooting the issue. Have you tried clearing your cache maybe? Also I assume that you know that the autoCommitEdit isn't enabled by default (neither is in the demo and neither is in the animated gif that you provided, you must click the checkbox "Auto Commit Edit" for it to be enabled).

[roopeshkurian]

I found that, After changing values, if I use TAB or 'Enter' key the value gets changed. But If I use the mouse to navigate to the next cell value is not updating.

[ghiscoding]

ok I see now, I'm able to reproduce and I'll see what I can do in the next few days to fix this since it's quite a bug indeed. Thanks for the reproduction. Strangely it doesn't have that problem in Slickgrid-Universal itself, but I see the same bug in Aurelia-Slickgrid.

[ghiscoding]

@roopeshkurian thanks for reporting this and providing ways to replicate, it was a hard one to fix and it took a lot of troubleshooting and digging. The new release v5.6.0 should resolve all issues, make sure to also update any Slickgrid-Universal dependency you might have. Cheers

[roopeshkurian]

Thank you so much for solving it. Like always you were so prompt to address this issue and solve it. It was a great help. Once again thank you :-)

[ghiscoding]

Welcome thanks for using the lib 😉 🎉