fix: Edit cell mouseout should save & excel copy should work, fix #1103 #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes #1103 caused by a regression introduced in Slickgrid-Universal PR [901](ghiscoding/slickgrid-universal#901) - requires Slickgrid-Universal PR [917](ghiscoding/slickgrid-universal#917) to be merged and released - the regression came after I wanted to fix another bug which was that making a cell range and Copy+Paste wasn't working, when fixing that bug it caused a new bug (this regression). This PR should fix both of these bugs and remove a very old hack that was introduced with `suppressActiveCellChangeOnEdit` which is no longer required - added Cypress E2E tests to cover the bug identified in #1103
ghiscoding
added
the
requires Universal change/release
Codecov Report
@@ Coverage Diff @@
## master #1104 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 914 914
Branches 320 320
=========================================
Hits 914 914
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ghiscoding
commented
Feb 23, 2023
| @@ -1,4 +1,4 @@ | |||
| describe('Example 3 - Grid with Editors', { retries: 1 }, () => { | |||
| describe('Example 3 - Grid with Editors', { retries: 0 }, () => { | |||
There was a problem hiding this comment.
need to rollback to 1 retry
ghiscoding
deleted the
bugfix/remove-usage-of-suppressActiveCellChangeOnEdit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suppressActiveCellChangeOnEditwhich is no longer requiredTODO