Skip to content

Commit

Permalink
feat(common): remove jquery-ui-dist from deps, use jquery-ui only (#733)
Browse files Browse the repository at this point in the history
* feat(common): remove jquery-ui-dist from deps, use jquery-ui only
- the dependency "jquery-ui-dist" was added for convenience (all-in-one) but wasn't managed by the jQuery team and it is now behind in version, it is missing a security patch and so this PR removes the use of that external "jquery-ui-dist", we should rely only on the official package "jquery-ui" which is maintained by the jQuery team
  • Loading branch information
ghiscoding authored Aug 3, 2022
1 parent ed00e2d commit b89d1f1
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
1 change: 0 additions & 1 deletion packages/common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@
"flatpickr": "^4.6.13",
"jquery": "^3.6.0",
"jquery-ui": "^1.13.2",
"jquery-ui-dist": "^1.13.1",
"moment-mini": "^2.24.0",
"multiple-select-modified": "^1.3.17",
"slickgrid": "^2.4.45",
Expand Down
8 changes: 0 additions & 8 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion test/jest-pretest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import * as jQuery from 'jquery';
// (global as any).Storage = window.localStorage;
(global as any).navigator = { userAgent: 'node.js' };
(global as any).Slick = (window as any).Slick = {};
require('jquery-ui-dist/jquery-ui');

require('jquery-ui/dist/jquery-ui.js');
require('slickgrid/lib/jquery.event.drag-2.3.0');
require('slickgrid/slick.core');
require('slickgrid/slick.dataview');
Expand Down

0 comments on commit b89d1f1

Please sign in to comment.